Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue in redundancy removal #280

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

blegat
Copy link
Member

@blegat blegat commented Nov 27, 2021

For the example of #279, this PR gives almost a 10x speedup!
Before:

0.159333 seconds (63.51 k allocations: 8.252 MiB)

After:

0.018471 seconds (10.34 k allocations: 909.406 KiB)

Closes #279

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #280 (704e4eb) into master (0288f27) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   88.14%   88.34%   +0.20%     
==========================================
  Files          37       37              
  Lines        2894     2901       +7     
==========================================
+ Hits         2551     2563      +12     
+ Misses        343      338       -5     
Impacted Files Coverage Δ
src/opt.jl 89.53% <100.00%> (+5.81%) ⬆️
src/redundancy.jl 91.24% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0288f27...704e4eb. Read the comment docs.

@blegat blegat merged commit cfa465f into master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of time spent interpolating strings
1 participant