implement sethrep for interval #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 78.08% 87.86% +9.77%
==========================================
Files 39 37 -2
Lines 3212 2867 -345
==========================================
+ Hits 2508 2519 +11
+ Misses 704 348 -356
Continue to review full report at Codecov.
|
blegat
approved these changes
Jul 27, 2021
blegat
requested changes
Jul 27, 2021
schillic
reviewed
Jul 27, 2021
src/interval.jl
Outdated
Comment on lines
203
to
209
| function sethrep!(p::Interval{T, AT}, h::HRep) where {T, AT} | ||
| hnew, v, volume = _hinterval(h, AT) | ||
| hrep = hnew | ||
| vrep = v | ||
| length = volume | ||
| return p | ||
| end |
There was a problem hiding this comment.
Do the three lines in the middle have any effect? If not, then this method does not modify p (as probably intended).
There was a problem hiding this comment.
Yes you're right thank you! I'll change that
blegat
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the constructors into helpers as suggested in the issue. And implementation of
sethrep!Closes #263