Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid zero division in decompose #248

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Avoid zero division in decompose #248

merged 2 commits into from
Apr 21, 2021

Conversation

blegat
Copy link
Member

@blegat blegat commented Apr 21, 2021

This is making CDDLib and Polyhedra tests fail in Julia v1.6 due to the change fixed in JuliaLang/julia#40551

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #248 (d851b8a) into master (57858dc) will increase coverage by 1.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   76.46%   78.12%   +1.66%     
==========================================
  Files          39       39              
  Lines        2961     3204     +243     
==========================================
+ Hits         2264     2503     +239     
- Misses        697      701       +4     
Impacted Files Coverage Δ
src/vecrep.jl 100.00% <ø> (ø)
src/decompose.jl 73.38% <100.00%> (+2.59%) ⬆️
src/indices.jl 96.92% <0.00%> (-3.08%) ⬇️
src/comp.jl 91.30% <0.00%> (-1.01%) ⬇️
src/planar.jl 100.00% <0.00%> (ø)
src/mixedrep.jl 100.00% <0.00%> (ø)
src/polyhedron.jl 100.00% <0.00%> (ø)
src/triangulation.jl 100.00% <0.00%> (ø)
src/interval.jl 99.13% <0.00%> (+0.02%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57858dc...d851b8a. Read the comment docs.

@blegat blegat merged commit 307644b into master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant