Add maximum_radius_with_center #232
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 90.16% 89.45% -0.72%
==========================================
Files 38 38
Lines 2532 2333 -199
==========================================
- Hits 2283 2087 -196
+ Misses 249 246 -3
Continue to review full report at Codecov.
|
src/center.jl
Outdated
| return zero(T) | ||
| end | ||
| else | ||
| radius = min(radius, (hs.β - center ⋅ hs.a) / n) |
There was a problem hiding this comment.
I think this won't work at the first iteration because:
julia> min(nothing, 2.5)
ERROR: MethodError: no method matching isless(::Float64, ::Nothing)
Closest candidates are:
isless(::Missing, ::Any) at missing.jl:87
isless(::Float64, ::Float64) at float.jl:465
isless(::AbstractFloat, ::AbstractFloat) at operators.jl:165
...Shall we add a check above? Something like isnothing(radius) && (radius = (hs.β - center ⋅ hs.a) / n)?
There was a problem hiding this comment.
Actually, adding isnothing(radius) && (radius = (hs.β - center ⋅ hs.a) / n) is not ideal because radius = min(radius, (hs.β - center ⋅ hs.a) / n) would run afterwards unnecessarily. Adding another branch to the if statement may be better.
35eaab2
to
074c132
Compare
|
While writing the basic tests for this I noticed a case for which Example: julia> p = hrep([1 1; -1 -1], [0, -1])
H-representation MixedMatHRep{Int64,Array{Int64,2}}:
2-element iterator of HalfSpace{Int64,Array{Int64,1}}:
HalfSpace([1, 1], 0)
HalfSpace([-1, -1], -1)
julia> r = Polyhedra.maximum_radius_with_center(p, zeros(2))
-0.7071067811865475 |
Adds `maximum_radius_with_center` entry to docs
cc @ferrolho