Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement named dimensions #225

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Implement named dimensions #225

merged 3 commits into from
Oct 22, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Oct 18, 2020

The LPHRep use a MathOptInterface model to encode the H-representation.
As this model natively supports naming the variables, LPHRep actually supports naming the dimensions.
This PR allows to retrieve these, pass these names along through transformations and sets these names to JuMP variables if the H-representation is used to create a vector of JuMP variables.

@coveralls
Copy link

coveralls commented Oct 18, 2020

Coverage Status

Coverage decreased (-1.0%) to 90.791% when pulling 407def5 on bl/dimension_names into 7144333 on master.

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #225 into master will decrease coverage by 1.30%.
The diff coverage is 68.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   90.79%   89.48%   -1.31%     
==========================================
  Files          37       38       +1     
  Lines        2215     2311      +96     
==========================================
+ Hits         2011     2068      +57     
- Misses        204      243      +39     
Impacted Files Coverage Δ
src/tmp.jl 0.00% <0.00%> (ø)
src/extended.jl 92.85% <83.33%> (-4.58%) ⬇️
src/lphrep.jl 88.09% <91.66%> (+0.25%) ⬆️
src/opt.jl 82.89% <92.85%> (-0.72%) ⬇️
src/default.jl 84.84% <96.00%> (+1.86%) ⬆️
src/center.jl 96.00% <100.00%> (ø)
src/projection_opt.jl 65.51% <100.00%> (-4.86%) ⬇️
src/repop.jl 90.52% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7144333...407def5. Read the comment docs.

@blegat blegat merged commit 15e8f7b into master Oct 22, 2020
@chachaleo chachaleo mentioned this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants