Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialized planar convex hull #223

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Specialized planar convex hull #223

merged 5 commits into from
Sep 29, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Sep 28, 2020

The 3D decomposition had a computation of the convex hull of the 2D facets that also supports rays and lines for a while, this PR extracts it as a separate planar_hull that is now called in removevredundancy! for 2D polyhedra.

@coveralls
Copy link

coveralls commented Sep 28, 2020

Coverage Status

Coverage increased (+0.3%) to 91.783% when pulling 3ea7eb8 on bl/planar_convex into e03b49c on master.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #223 into master will increase coverage by 0.06%.
The diff coverage is 79.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   90.72%   90.79%   +0.06%     
==========================================
  Files          36       37       +1     
  Lines        2157     2215      +58     
==========================================
+ Hits         1957     2011      +54     
- Misses        200      204       +4     
Impacted Files Coverage Δ
src/Polyhedra.jl 84.00% <ø> (ø)
src/recipe.jl 96.29% <ø> (+2.96%) ⬆️
src/decompose.jl 71.55% <37.77%> (-8.76%) ⬇️
src/planar.jl 100.00% <100.00%> (ø)
src/redundancy.jl 95.48% <100.00%> (+0.06%) ⬆️
src/elements.jl 84.40% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03b49c...3ea7eb8. Read the comment docs.

@blegat blegat merged commit 7144333 into master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants