Add missing get/set MPI.File info functions #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
reviewed
Sep 4, 2020
|
Also looks like you pushed this to master already? I'll revert that for now. |
|
Whoops, that was a mistake. It seems like openmpi doesn't fill in the tested reserved kwargs by default as well. |
jakebolewski
force-pushed
the
jcb/file_info
branch
2 times, most recently
from
7fe9e74
to
74d2d6e
Compare
simonbyrne
reviewed
Sep 4, 2020
jakebolewski
force-pushed
the
jcb/file_info
branch
3 times, most recently
from
8833317
to
0b618c3
Compare
jakebolewski
force-pushed
the
jcb/file_info
branch
from
0b618c3
to
2789705
Compare
simonbyrne
reviewed
Sep 8, 2020
| @test length(keys(fh_info)) == 0 | ||
|
|
||
| # Test that default info hints on mpi-io implementation are present | ||
| @test parse(Int, fh_info[:coll_write_bufsize]) > 0 |
There was a problem hiding this comment.
This is causing the error:
https://travis-ci.com/github/JuliaParallel/MPI.jl/jobs/381341367#L6871
There was a problem hiding this comment.
I think i need to play around with OpenMPI's MPI IO implementation some more to understand what the defaults are across different versions. The CI build also doesn't seem to preserve valid file hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.