Add eager_mode() definition and call in __init__()
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New work on BB2 will create a `LazyJLLWrappers` that has a (slightly) different API, and is lazily-loaded. In order to be compatible with JLLs that still use `JLLWrappers`, we define an `eager_mode()` method that eagerly loads all libraries for use in a downstream JLL that still uses `JLLWrappers`. This PR adds no-op `eager_mode()` implementations for all old JLLs, and invokes `eager_mode()` on all dependencies to pave the way for this interopability.
staticfloat
force-pushed
the
sf/eager_mode
branch
from
6b8ac59
to
9d34289
Compare
staticfloat
added a commit
to JuliaPackaging/BinaryBuilder2.jl
that referenced
this pull request
Mar 27, 2024
We can actually co-exist with JLLWrappers with a little bit of extra work, adding an `eager_mode()` function [0]. This allows us to have fully lazy semantics when the entire tree of dependencies is using `LazyJLLWrappers`, but subtrees that have old `JLLWrappers` JLLs will all be flipped into eager mode. X-ref: JuliaPackaging/JLLWrappers.jl#61
|
@giordano FYI. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New work on BB2 will create a
LazyJLLWrappersthat has a (slightly) different API, and is lazily-loaded. In order to be compatible with JLLs that still useJLLWrappers, we define aneager_mode()method that eagerly loads all libraries for use in a downstream JLL that still usesJLLWrappers.This PR adds no-op
eager_mode()implementations for all old JLLs, and invokeseager_mode()on all dependencies to pave the way for this interopability.