Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apple PowerPC build #276

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

Apple versions of GCC define ppc instead of powerpc

Fixes #275

Apple versions of GCC define __ppc__ instead of __powerpc__

Fixes JuliaMath#275
@ViralBShah ViralBShah merged commit 12f5ffc into JuliaMath:master Jun 25, 2023
@barracuda156
Copy link
Contributor

@MarcusCalhoun-Lopez @ViralBShah I apologize, I missed this somehow. We also need __ppc64__ there, I believe, or otherwise __POWERPC__ includes both for Apple (and, well, also includes BeOS).

@ViralBShah
Copy link
Member

Submit another PR?

@barracuda156
Copy link
Contributor

Submit another PR?

@ViralBShah Well, #303 (I know, yeah)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on macOS with GCC: s_fpclassify.c: error: storage size of 'u' isn't known
3 participants