Make fenv methods static on additional platforms. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @maleadt . This fixed the issue on aarch64 atleast. |
|
Great. @staticfloat Good to go, merge, tag, bump Yggdrasil, include in 1.6? I'll do most of that, but don't have permissions to merge and tag here. |
|
You have been added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref JuliaLang/julia#39462, JuliaLang/julia#38466. Similarly to #219, this makes sure we don't export
fenvroutines on some additional platforms (being conservative here and only using those for which CUDA, which relies on this behavior, is available).