Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Apple PowerPC build #276

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Fix Apple PowerPC build #276

merged 1 commit into from
Jun 25, 2023

Conversation

MarcusCalhoun-Lopez
Copy link
Contributor

Apple versions of GCC define ppc instead of powerpc

Fixes #275

@MarcusCalhoun-Lopez
Fix Apple PowerPC build
00eaec9 
Apple versions of GCC define __ppc__ instead of __powerpc__

Fixes JuliaMath#275
@ViralBShah ViralBShah merged commit 12f5ffc into JuliaMath:master Jun 25, 2023
6 checks passed
@barracuda156
Copy link
Contributor

@MarcusCalhoun-Lopez @ViralBShah I apologize, I missed this somehow. We also need __ppc64__ there, I believe, or otherwise __POWERPC__ includes both for Apple (and, well, also includes BeOS).

@ViralBShah
Copy link
Member

Submit another PR?

@ViralBShah ViralBShah mentioned this pull request Jun 29, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Feb 18, 2024
Merged
@barracuda156
Copy link
Contributor

Submit another PR?

@ViralBShah Well, #303 (I know, yeah)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails on macOS with GCC: s_fpclassify.c: error: storage size of 'u' isn't known
3 participants
@MarcusCalhoun-Lopez @barracuda156 @ViralBShah