modify degree for Poly([0.0]); polyder #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two small suggestions: * modify degree to return 0 for Poly([0.0]). Otherwise, recent change to * has issues * change factorial(i)/factorial(i-order) to prod(i-order+1:i) in polyder to avoid OverFlow error.
|
Add a testcase, maybe? |
|
Good idea! This caused an issue with divrem's check for pNULL. That is now addressed and tests pass. |
|
Thanks! |
Keno
added a commit
that referenced
this pull request
Jul 7, 2014
modify degree for Poly([0.0]); polyder
|
I've also given you push access to the repository. Feel free to make any reasonable changes. All I'd ask is that the test suite is kept in good passing order. |
|
Will do. Thanks again. On Sun, Jul 6, 2014 at 8:16 PM, Keno Fischer [email protected]
John Verzani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small suggestions: