Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out MakieCore for Requires #577

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

jverzani
Copy link
Member

Work around 1.6 issue by loading Requires

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.69%. Comparing base (2ddb628) to head (4e1c1a2).

Files Patch % Lines
src/Polynomials.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   75.69%   75.69%   -0.01%     
==========================================
  Files          38       38              
  Lines        4037     4040       +3     
==========================================
+ Hits         3056     3058       +2     
- Misses        981      982       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani jverzani merged commit 0c8c060 into JuliaMath:master Jun 14, 2024
20 of 22 checks passed
@jverzani jverzani deleted the issue_575 branch June 14, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant