Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests and documentation patch #571

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Conversation

abhro
Copy link
Contributor

@abhro abhro commented May 19, 2024

Main changes:

  • Add more doctests
  • Add syntax highlighting tags for code examples
  • Remove unnecessary naming from doctests that cause them to share scope (no variables are shared, scope sharing isn't necessary)
  • Pull items into lists

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.69%. Comparing base (87f02db) to head (67a3ad9).

Files Patch % Lines
...c/rational-functions/rational-transfer-function.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   75.69%   75.69%           
=======================================
  Files          38       38           
  Lines        4037     4037           
=======================================
  Hits         3056     3056           
  Misses        981      981           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani
Copy link
Member

jverzani commented Jun 7, 2024

Thanks so much for this! Apologies for taking so long to merge, I had missed the notification.

@jverzani jverzani merged commit 8b8055d into JuliaMath:master Jun 7, 2024
19 of 22 checks passed
@abhro abhro deleted the doctests-patch-1 branch June 7, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants