Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using Aqua v0.8 #545

Closed
wants to merge 1 commit into from
Closed

Test using Aqua v0.8 #545

wants to merge 1 commit into from

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Dec 1, 2023

Also, rewrite method signatures to get all the Aqua tests to pass. The idea there is that in the NTuple{N,T} form, T isn't known if N==0. Rewriting this as Tuple{T, Vararg{T}} ensures that T is not ambiguous.

@jverzani
Copy link
Member

jverzani commented Dec 2, 2023

Thanks. You taught me about Vararg! Any thoughts on the stack overflow that happens with the ImmutablePolynomial type? (I didn't check,but my guess is there is an option to cut out a constructor.) I can pursue if you don't know right away what is up.

@jverzani
Copy link
Member

jverzani commented Dec 3, 2023

Thanks,I merged this as part of #546. Hope I didn't miss the intent with my modifications. Do let me know if I missed something.

@jverzani jverzani closed this Dec 3, 2023
@jishnub jishnub deleted the aqua branch December 3, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants