Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for v0.5: replace symbol with Symbol #46

Merged
merged 1 commit into from
May 30, 2016
Merged

for v0.5: replace symbol with Symbol #46

merged 1 commit into from
May 30, 2016

Conversation

JeffreySarnoff
Copy link
Member

I am assuming that Compat will do the right thing with the v0.5 deprecated 'symbol' when using v0.4.
It is here if you want it.

`polyfit(x, y, n=length(x)-1, sym=:x )`: Fit a polynomial of degree
`n` through the points specified by `x` and `y` where `n <= length(x)
- 1` using least squares fit. When `n=length(x)-1` (the default), the
interpolating polynomial is returned. The optional fourth argument can
be used to pass the symbol for the returned polynomial.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here can mess up doc formatting.

@yuyichao
Copy link
Collaborator

0.3 is still supported and tested so you need @compat and also bump the required Compat version to 0.7.15.

@Jeffrey-Sarnoff
Copy link

Jeffrey-Sarnoff commented May 23, 2016

@yuyichao I see that Compat.jl has

if ...
elseif VERSION < v"0.5.0-dev+3831"
    Base.Symbol(args...) = symbol(args...)
end

After bumping the version in REQUIRE, if I have

using Compat
import Compat.Symbol

do I still need @compat? if so, @compat (What goes here)

@JeffreySarnoff
Copy link
Member Author

apologies for the doubled github idents (my mistake).

@yuyichao
Copy link
Collaborator

@yuyichao
Copy link
Collaborator

And yes, you always need @compat for 0.3 support of calling Symbol and no you shouldn't import it (Symbol) from Compat.

@Jeffrey-Sarnoff
Copy link

@yuyichao Thank you for the help.

@Keno Keno merged commit 2ce7b4a into JuliaMath:master May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants