Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia v0.7 compatibility - lastindex/range #135

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

pjabardo
Copy link
Contributor

@pjabardo pjabardo commented Mar 6, 2018

The function endof is now lastindex and linspace was substituted by
range using keyword arguments. Another change is from reprmime to repr.

In some cases simply using Compat was enough. In some of the tests,
the version number was explicitly called: I Compat wasn't enough.

There are still a few warnings when testing in v 0.7 in the tests that I can not figure out where they come from such as:

┌ Warning: `x ^ p::Integer` is deprecated, use `Base.power_by_squaring(x, p)` instead.
│   caller = @generated body at none:0 [inlined]
└ @ Core none:0

or

┌ Warning: `conj(x)` is deprecated, use `x` instead.
│   caller = top-level scope
└ @ Core :0

Other than that the tests pass for version 0.6.2 and 0.7

The function `endof` is now `lastindex` and `linspace` was substituted by
`range` using keyword arguments. Another change is from `reprmime` to `repr`.

In some cases simply using Compat was enough. In some of the tests,
the version number was explicitly called: I Compat wasn't enough.
@martinholters
Copy link
Contributor

Bump. Would be nice to get lastindex(::Poly). E.g. DSP.jl needs it.

@martinholters
Copy link
Contributor

Bumpity.

@ararslan ararslan merged commit 992bfaf into JuliaMath:master Mar 23, 2018
@ararslan
Copy link
Member

Thanks, and sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants