Add a dependency on AbstractFFTs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Jun 6, 2017
test/runtests.jl
Outdated
| @@ -2,6 +2,7 @@ | |||
| using FFTW | |||
| using Base.Test | |||
|
|
|||
| importall AbstractFFTs | |||
| importall FFTW | |||
There was a problem hiding this comment.
Why do the tests need importall and not just using?
There was a problem hiding this comment.
To make sure these names get picked up rather than the ones from Base
ararslan
force-pushed
the
aa/abstractffts
branch
2 times, most recently
from
d9b364e
to
81fcfb6
Compare
|
Wooooooooo tests are passing now! Want to take another look, @stevengj? |
|
Lgtm |
|
The macOS errors don't seem related to the package, but they are strange. I wonder if there's something I need to do differently with the Travis setup for Homebrew to work? Edit: Nope, looks like it was due to the GitHub maintenance outage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2