Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround JuliaLang/julia#26827 by adding type assertions #68

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Workaround JuliaLang/julia#26827 by adding type assertions #68

merged 1 commit into from
Apr 18, 2018

Conversation

martinholters
Copy link
Collaborator

No description provided.

@ararslan
Copy link
Member

Maybe add some @test @inferreds?

@martinholters
Copy link
Collaborator Author

We already have:

FFTW.jl/test/runtests.jl

Line 361 in 669db59

@inferred rfft(x)

FFTW.jl/test/runtests.jl

Line 368 in 669db59

@inferred brfft(y,10)

FFTW.jl/test/runtests.jl

Lines 369 to 372 in 669db59

for f in (plan_bfft!, plan_fft!, plan_ifft!,
plan_bfft, plan_fft, plan_ifft,
fft, bfft, fft_, ifft)
p = @inferred f(z)

And those do fail on current master, as seen e.g. in the test logs of pkgeval (starting on 2018-04-14).

@ararslan
Copy link
Member

Okay cool, thanks.

@ararslan ararslan merged commit 4bb7d0d into master Apr 18, 2018
@ararslan ararslan deleted the mh/workaround_26827 branch April 18, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinholters @ararslan