Mention GPL in the README #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #39. [ci skip]
stevengj
reviewed
Sep 29, 2017
| as part of Julia. | ||
| Note that FFTW is licensed under GPLv2 or higher (see | ||
| [its license file](http:https://www.fftw.org/doc/License-and-Copyright.html)), but the bindings | ||
| here are licensed under MIT. |
There was a problem hiding this comment.
This is a bit unclear. Best to spell out the consequences:
This means that code using the FFTW library via the FFTW.jl bindings is subject to FFTW's licensing terms. Code using alternative implementations of the FFTW API, such as [MKL's FFTW3 interface](https://software.intel.com/en-us/mkl-developer-reference-c-fftw3-interface-to-intel-math-kernel-library) are instead subject to the alternative's license.
There was a problem hiding this comment.
Ah yes, MKL deserves a mention here, but I'm unclear on what "code using the FFTW library via the FFTW.jl bindings is subject to FFTW's licensing terms" means.
There was a problem hiding this comment.
If you distribute a derived/combined work, i.e. a program that links to FFTW, then that distribution falls under the terms of the GPL (e.g. must include complete source code etc.)
If you just distribute source code that links to FFTW.jl, and users have to download FFTW or MKL to provide the backend, then the GPL probably doesn't have much effect on you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39.
Note: CI skipped, remove from commit message when merging.