Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: for the macOS CI jobs with the MKL provider, force MKL_jll 2023 to be installed #286

Merged
merged 3 commits into from
Dec 10, 2023
Merged

CI: for the macOS CI jobs with the MKL provider, force MKL_jll 2023 to be installed #286

merged 3 commits into from
Dec 10, 2023

Conversation

DilumAluthge
Copy link
Contributor

@DilumAluthge DilumAluthge commented Dec 10, 2023 •
edited

In MKL 2024, Intel dropped support for macOS.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76732cd) 70.88% compared to head (4bd5b40) 70.88%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   70.88%   70.88%           
=======================================
  Files           5        5           
  Lines         529      529           
=======================================
  Hits          375      375           
  Misses        154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge DilumAluthge marked this pull request as ready for review December 10, 2023 20:32
@giordano
Copy link
Member

Use MKL 2023 for testing those jobs, so we do something actually useful?

@DilumAluthge DilumAluthge marked this pull request as draft December 10, 2023 21:18
@DilumAluthge DilumAluthge changed the title CI: don't run the macOS CI jobs with the MKL provider CI: for the macOS CI jobs with the MKL provider, force MKL_jll 2023 to be installed Dec 10, 2023
@DilumAluthge
Copy link
Contributor Author

Use MKL 2023 for testing those jobs, so we do something actually useful?

Done!

@DilumAluthge DilumAluthge marked this pull request as ready for review December 10, 2023 21:41
@DilumAluthge DilumAluthge merged commit 7acdc2b into master Dec 10, 2023
32 checks passed
@DilumAluthge DilumAluthge deleted the dpa/mkl-2024-macos branch December 10, 2023 23:40
@ericphanson
Copy link

ericphanson commented Dec 15, 2023 •
edited

What about using Pkg.add then Pkg.pin so it can't re-resolve it? (@palday's idea in an unrelated repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

@ChrisRackauckas ChrisRackauckas Awaiting requested review from ChrisRackauckas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DilumAluthge @giordano @ericphanson