remove tuple specialization of fix_kinds #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 69.47% 69.23% -0.25%
==========================================
Files 5 5
Lines 498 494 -4
==========================================
- Hits 346 342 -4
Misses 152 152
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Gentle bump @stevengj . This will be mildly breaking, but overall having this return the same type in all calls would significantly ease development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
fix_kindsmethod that evaluates to aTuple. This was introduced in #253 as a constant-propagation hack, but it's unnecessary now, given that the value is stored as a field rather than as a type-parameter. Having the method uniformly return aVector{Int32}will firstly reduce unnecessary compilation, and secondly make the type parameters more predictable. The result has to be materialized in any case to create the plan, so this doesn't add to allocations.