improve type inference in DCTPlan #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
The CI failure looks a little concerning? But maybe unrelated? |
|
The CI failure on MKL windows is likely a timeout, as there seems to have been some Github actions outage (#260), The failure on MKL macOS is more serious, but that's present on all recent PRs and is unrelated to this. |
|
@giordano The registry cloning issue seems persistent, and is regularly taking 6-8 minutes on some jobs. However, it does successfully get cloned after that, and doesn't hang indefinitely. Some of the running CI jobs are getting cancelled because of the 10-minute limit. GitHub's status shows all green, so perhaps this isn't a glitch, rather a slow server? Interestingly, the timeout is always on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameterizes a
DCTPlanfor better type inference. With #253, this should make aDCTPlantype-stable.