Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test_broken on master #257

Merged
merged 2 commits into from
Jan 11, 2023
Merged

remove test_broken on master #257

merged 2 commits into from
Jan 11, 2023

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Jan 11, 2023

Some of these inference tests are passing on recent Julia versions, but @test_broken would silently ignore non-boolean values. This has been fixed in Julia Base recently, leading to test failures on nightly. With this PR, tests should work on nightly again.

@stevengj stevengj merged commit 7412b3e into JuliaMath:master Jan 11, 2023
@jishnub jishnub deleted the testbroken branch January 11, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants