Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference + allocation in fix_kinds #254

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Oct 20, 2022

Rename the output variable to make the result exactly inferred, and reduce temporary allocations.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 61.28% // Head: 60.91% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (ae18c9b) compared to base (17bc81a).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   61.28%   60.91%   -0.37%     
==========================================
  Files           5        5              
  Lines         483      481       -2     
==========================================
- Hits          296      293       -3     
- Misses        187      188       +1     
Impacted Files Coverage Δ
src/fft.jl 60.89% <83.33%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Contributor Author

jishnub commented Oct 20, 2022

Test failure is unrelated

src/fft.jl Outdated Show resolved Hide resolved
src/fft.jl Outdated Show resolved Hide resolved
@stevengj stevengj merged commit 6f123e8 into JuliaMath:master Oct 26, 2022
@jishnub jishnub deleted the fixkindsalloc branch March 28, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants