Make FFTW relocatable for PackageCompiler #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we need to know the FFTW vendor pretty early (at precompile
time to generate code, and at runtime) we need to load the path during
build (which bakes it into the precompile image), however we need to
update that path on next load within `__init__()` in case we're a part
of PackageCompiler and we need to be able to move things around without
requiring a recompile. So we change all accesses of `libfftw3{,f}` to
be through a `Ref{String}()`, then update that ref within `__init__()`.
In the future, accesses of `FFTW_jll.libfftw3` will be through a
function, rather than a direct variable access, and we'll be able to get
these things for free, but that's still a ways down the line.
staticfloat
force-pushed
the
sf/relocatable
branch
from
9ad65a9
to
e96270a
Compare
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 62.64% 62.85% +0.20%
==========================================
Files 5 5
Lines 423 428 +5
==========================================
+ Hits 265 269 +4
- Misses 158 159 +1
Continue to review full report at Codecov.
|
stevengj
approved these changes
Jun 16, 2021
|
We've now been able to test this and it makes the package work with PackageCompiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we need to know the FFTW vendor pretty early (at precompile
time to generate code, and at runtime) we need to load the path during
build (which bakes it into the precompile image), however we need to
update that path on next load within
__init__()in case we're a partof PackageCompiler and we need to be able to move things around without
requiring a recompile. So we change all accesses of
libfftw3{,f}tobe through a
Ref{String}(), then update that ref within__init__().In the future, accesses of
FFTW_jll.libfftw3will be through afunction, rather than a direct variable access, and we'll be able to get
these things for free, but that's still a ways down the line.