Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MassInstallAction: Install the CI workflow on this repository #172

Merged
merged 4 commits into from
Dec 26, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 24, 2020

This pull request sets up the CI workflow on this repository.

@timholy
Copy link
Member Author

timholy commented Dec 24, 2020

Someone who knows a bit more about this package should look this over. I'm not sure of whether the ENV variables in the .travis.yml script should be used in "matrix" format and in what stage of the build process.

In case it's not clear, the reason for this PR is that travis.org goes away in a week, and travis.com won't be free. So view this PR as a downpayment on the migration, but it will require the touch of someone who knows what s/he is doing.

@giordano
Copy link
Member

I'll do it later

@giordano giordano force-pushed the massinstallaction/set-up-CI branch 5 times, most recently from d63001e to 60b6077 Compare December 25, 2020 00:07
@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@130e9a0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #172   +/-   ##
=========================================
  Coverage          ?   67.75%           
=========================================
  Files             ?        3           
  Lines             ?      400           
  Branches          ?        0           
=========================================
  Hits              ?      271           
  Misses            ?      129           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130e9a0...b90e59c. Read the comment docs.

@giordano giordano force-pushed the massinstallaction/set-up-CI branch 2 times, most recently from 357ca3f to dc3ef53 Compare December 25, 2020 00:15
@giordano
Copy link
Member

giordano commented Dec 25, 2020

Ok, after a few attempts I think I reproduced the same setup as Travis before. The failure on Windows + Julia nightly + MKL is unrelated (and very weird: JuliaLang/julia#38993)

@giordano
Copy link
Member

giordano commented Dec 25, 2020

Is there a built-in way to tell whether FFTW or MKL is being used? I can think of showing the value of FFTW.libfftw3, but maybe there are better ways. I find it quite strange that the size of the artifacts is only ~3 MiB, which is the size of the FFTW artifact only. MKL doesn't seem to be actually used? Edit: nevermind, the failing job indicates that MKL is indeed used. Still confused by why it doesn't appear in the cache

@timholy
Copy link
Member Author

timholy commented Dec 26, 2020

While I don't have the expertise to give this a serious review, this looks really nice to me. Thanks!

@giordano
Copy link
Member

Ok, I'm going to merge, if there are some details to fix we can do it afterwards, but at least we can keep CI going.

@giordano giordano merged commit fc827d7 into master Dec 26, 2020
@giordano giordano deleted the massinstallaction/set-up-CI branch December 26, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants