Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare kwarg to test_density_interface #6

Merged
merged 2 commits into from
Nov 7, 2021
Merged

Conversation

oschulz
Copy link
Collaborator

@oschulz oschulz commented Nov 7, 2021

We use ref_d_at_x = exp(ref_logd_at_x) in test_density_interface, so comparison shouldn't be exact by default.

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #6 (a0da449) into master (104dac4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           36        36           
=========================================
  Hits            36        36           
Impacted Files Coverage Δ
src/interface_test.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104dac4...a0da449. Read the comment docs.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we shouldn't check equality 👍

src/interface_test.jl Outdated Show resolved Hide resolved
@oschulz
Copy link
Collaborator Author

oschulz commented Nov 7, 2021

Good with you this way, @devmotion ?

@oschulz oschulz merged commit a0da449 into master Nov 7, 2021
@oschulz oschulz deleted the approx-testfunc branch November 7, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants