Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update build status badage #27

Merged
merged 1 commit into from
Jun 4, 2024
Merged

CI: update build status badage #27

merged 1 commit into from
Jun 4, 2024

Conversation

inkydragon
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a234a9a) to head (505c0c6).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           63        63           
=========================================
  Hits            63        63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inkydragon inkydragon merged commit c1dd616 into master Jun 4, 2024
10 checks passed
@inkydragon inkydragon deleted the inkydragon-patch-1 branch June 4, 2024 23:10
@devmotion
Copy link
Member

@inkydragon why was this merged without review? The general policy is to only merge PRs after they have been approved. IMO this PR "break"s the link to the action results (it intentionally linked to the runs from the master branch since possibly broken runs in possibly more recent PRs are irrelevant for the badge).

devmotion added a commit that referenced this pull request Jun 4, 2024
devmotion added a commit that referenced this pull request Jun 5, 2024
* Revert "CI: update build status badage (#27)"

This reverts commit c1dd616.

* Fix badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants