RFQ Add LikelihoodDensity as a typedef for existing implicit likelihood functionality #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oschulz
force-pushed
the
likelihood_density
branch
2 times, most recently
from
63c68eb
to
3c076e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
============================================
- Coverage 100.00% 89.70% -10.30%
============================================
Files 2 2
Lines 59 68 +9
============================================
+ Hits 59 61 +2
- Misses 0 7 +7
Continue to review full report at Codecov.
|
oschulz
force-pushed
the
likelihood_density
branch
from
3c076e5
to
a69a7c6
Compare
oschulz
force-pushed
the
likelihood_density
branch
from
a69a7c6
to
d114d99
Compare
oschulz
changed the title
|
Let's put a pin in this for a bit maybe, this maybe be better off in another package. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for a place to define generic likelihood densities and realised that they already exist in DensityInterface in an implicit fashion. This makes them visible and documents them.
CC @devmotion , @cscherrer