Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3 compatibility #8

Closed
stevengj opened this issue Apr 28, 2015 · 5 comments
Closed

0.3 compatibility #8

stevengj opened this issue Apr 28, 2015 · 5 comments

Comments

@stevengj
Copy link
Member

Currently, it only works with 0.4, which is not really acceptable.

stevengj added a commit that referenced this issue Apr 28, 2015
@stevengj
Copy link
Member Author

Got it at least loading with 0.3, but have some kind of weird corruption that I can't figure out in 0.3:

julia> using DecFP
julia> d"1.0"
+140734667966048E-398
julia> reinterpret(Uint64, d"1.0")
0x0000000000000000

Something has apparently changed with how bitstype is handled? (cc: @vtjnash)

I'm not sure it's actually worth it. I can just make this package require Julia 0.4.

@vtjnash
Copy link

vtjnash commented Apr 28, 2015

it's quite possible the ccall fixes changed the calling convention for Dec128, depending on what the system you are on

@stevengj
Copy link
Member Author

But why would this affect Dec64 (on 64-bit MacOS X)?

@vtjnash
Copy link

vtjnash commented Apr 29, 2015

nvm, it shouldn't i just skimmed the code too quickly.

unrelated note: cglobal (like ccall) is a compile-time intrinsic, so it is zero-cost to copy it to each usage site (perhaps in macro form @flags to reduce typing?) instead of putting it in __init__

@PallHaraldsson
Copy link
Contributor

Just close, since "it only works with 0.4, which is not really acceptable" is just no longer true..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants