Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make R field in Schur concretely typed #92

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

dkarrasch
Copy link
Member

Fixes #90. By line 95,

τ = Rotation(Givens{T}[])

the R field has eltype T for sure.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Base: 81.29% // Head: 81.29% // No change to project coverage 👍

Coverage data is based on head (1a733e7) compared to base (85e6867).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files          10       10           
  Lines        1636     1636           
=======================================
  Hits         1330     1330           
  Misses        306      306           
Impacted Files Coverage Δ
src/eigenGeneral.jl 67.02% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkarrasch
Copy link
Member Author

Gentle bump.

@dkarrasch dkarrasch merged commit 1ae32bf into JuliaLinearAlgebra:master Nov 2, 2022
@dkarrasch dkarrasch deleted the dk/schurtype branch November 2, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotation field in Schur struct is abstractly typed
1 participant