Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 4 space indent in Markdown #9852

Merged
merged 1 commit into from
Jan 20, 2015
Merged

Conversation

hayd
Copy link
Member

@hayd hayd commented Jan 20, 2015

fixes #9849

cc @one-more-minute @jakebolewski

@hayd hayd mentioned this pull request Jan 20, 2015
@ivarne
Copy link
Sponsor Member

ivarne commented Jan 20, 2015

I love

git fetch https://github.com/hayd/julia.git markdown_indent
git show --ignore-space-change  e23a1921041482f8348b94b7acf827b61518a90f

That saved me an hour reviewing a change like this properly (so that I would be sure that this was purely whitespace changes)

ivarne added a commit that referenced this pull request Jan 20, 2015
Use 4 space indent in Markdown
@ivarne ivarne merged commit 39a498b into JuliaLang:master Jan 20, 2015
@hayd
Copy link
Member Author

hayd commented Jan 20, 2015

@hayd hayd deleted the markdown_indent branch January 20, 2015 16:49
@ivarne
Copy link
Sponsor Member

ivarne commented Jan 20, 2015

Nice!

(would've be nice to post that trick before this got merged)

Thanks!

@hayd
Copy link
Member Author

hayd commented Jan 20, 2015

@ivarne sorry, I had forgotten about it 'til you said!

@tkelman
Copy link
Contributor

tkelman commented Jan 21, 2015

@hayd that is an awesome trick - here's another great example of its usefulness: d952f5f?w=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

markdown code does not adhere to the conventions of base julia
3 participants