Remove as many generic error() messages from base as possible #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakebolewski
commented
Jan 19, 2015
jakebolewski
commented
- throw more specific Exception types
- make error messages more consistent
- give more context for the error when possible
- update tests
tkelman
added
the
domain:error handling
| @@ -21,9 +21,9 @@ end | |||
|
|
|||
| function IPv4(host::Integer) | |||
| if host < 0 | |||
| error("IP address must not be negative") | |||
| throw(ArgumentError("IPv4 address must not be ≥ 0")) | |||
There was a problem hiding this comment.
Isn't the sense on this statement wrong? The IPv4 must be positive.
There was a problem hiding this comment.
Do these inequality symbols display correctly on Windows?
There was a problem hiding this comment.
@GlenHertz thanks for reading through. "must be positive" I think is subjectively better than "not negative", I'll push an update.
@IainNZ I have no idea.
|
This is great, and much needed. |
jakebolewski
force-pushed
the
jcb/bettererrs
branch
from
e872e18
to
e5f245e
Compare
jakebolewski
changed the title
* throw more specific Exception types * make error messages more consistent * give more context for the error when possible * update tests
jakebolewski
force-pushed
the
jcb/bettererrs
branch
from
e5f245e
to
8f554df
Compare
|
I've updated with @GlenHertz's suggestions and did another pass over what I pushed last night. I also updated some of the errors in the |
|
Really nice work @jakebolewski ! |
|
👍 |
jakebolewski
added a commit
that referenced
this pull request
Jan 22, 2015
Remove as many generic error() messages from base as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.