Fleshed out complex.jl tests #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebolewski
added a commit
that referenced
this pull request
Jan 5, 2015
Fleshed out complex.jl tests
|
Thank you so much for all the tests you've been adding, @kshyatt. |
|
I ❤️ testing! |
|
I ❤️ people who ❤️ testing! :-) |
|
@kshyatt I just saw that you are at UCSB studying physics. Seems like we are getting some contributions from there. I am pretty sure I have seen a couple of commits from one other person in UCSB physics. Brings back fond memories - @StefanKarpinski and I both spent many years there! |
|
You are probably thinking of @garrison, who's in the same research group as me. Always nice to see some UCSB people doing awesome things. I ❤️ people who ❤️ those who ❤️ testing - it's |
|
backported the new tests in 72974fb, good times |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exp2,exp10, andcishad no tests. I added some for^andinvwhich had uncovered branches.