mention in contributing how to run specific tests #9610
Conversation
| @@ -8,6 +8,8 @@ Hi! Thanks for checking out Julia. If you have questions or problems, the [Julia | |||
|
|
|||
| * [Fork Julia](https://github.com/JuliaLang/julia/fork). | |||
|
|
|||
| * Sign up for [Travis](https://travis-ci.org/profile/) and switch on your julia fork. | |||
There was a problem hiding this comment.
this is not really required for the majority of contributors - it doesn't hurt anything to do, but most users won't have osx testing activated for their account, for example
There was a problem hiding this comment.
I would argue that most users wouldn't be doing mac specific things, I like tests to be green before making a PR, but agree appveyor won't run either.... removed!
There was a problem hiding this comment.
It can still be mentioned as an optional step, if people want to test privately on their own fork first and don't happen to have access to a Linux machine/VM themselves.
There was a problem hiding this comment.
@tkelman You want me to add this back (slightly reword and say "optionally")?
There was a problem hiding this comment.
Nah it can be left out, but it would be good to change the below line to say ./usr/bin/julia instead of ./julia so it works cross-platform.
tkelman
added
domain:docs
|
Bump. Change |
Also link to Github's "Good to merge" blog post
|
@tkelman fixed and squashed. |
mention in contributing how to run specific tests
|
Thanks! |
|
backported in 6b117b3 |
Also link to Github's "Good to merge" blog post