Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export deprecated TcpSocket, IpAddr #9495

Merged
merged 1 commit into from
Dec 30, 2014

Conversation

mlubin
Copy link
Member

@mlubin mlubin commented Dec 30, 2014

These weren't exported in 0.3

CC @sbromberger @jakebolewski

These weren't exported in 0.3
Closes JuliaLang#9492
@sbromberger
Copy link
Contributor

It seems strange to me that UdpSocket was exported, especially since it only appears in base/socket.jl. @Keno - is there a reason it should follow different behavior than its related classes?

@mlubin
Copy link
Member Author

mlubin commented Dec 30, 2014

Both UDPSocket and TCPSocket are now exported in 0.4, so not sure if there's an issue here.

@sbromberger
Copy link
Contributor

The result of this patch would bring 0.4 inline with 0.3 with respect to the export of UdpSocket, but I don't know why this (inconsistent) behavior exists in 0.3. Would it be better to file a PR against 0.3 making TcpSocket and IpAddr consistent with UdpSocket (likely by exporting them, so things don't break) first? Then, whatever we decide to do in 0.4 is consistent across all three types.

ETA: UdpSocket was added to exports via #5697

@mlubin
Copy link
Member Author

mlubin commented Dec 30, 2014

Can't comment on the utility of exporting since I'm not familiar with the code, but asking for changes in 0.3 will delay the resolution of this.

@mlubin
Copy link
Member Author

mlubin commented Dec 30, 2014

Another question is why deprecations are needed at all for names that weren't exported. It seems like the convention now is to make the old names available through Compat if needed.

JeffBezanson added a commit that referenced this pull request Dec 30, 2014
Don't export deprecated TcpSocket, IpAddr
@JeffBezanson JeffBezanson merged commit 8b855cc into JuliaLang:master Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants