Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention of join() to the section of the manual about strings #9426

Merged
merged 1 commit into from
Dec 20, 2014

Conversation

nalimilan
Copy link
Member

This is one of the very useful functions which can be hard to find,
and very similar to repeat().

This is one of the very useful functions which can be hard to find,
and very similar to repeat().
@ivarne ivarne added the domain:docs This change adds or pertains to documentation label Dec 20, 2014
@ivarne
Copy link
Sponsor Member

ivarne commented Dec 20, 2014

Looks good to me.

ivarne added a commit that referenced this pull request Dec 20, 2014
Add mention of join() to the section of the manual about strings
@ivarne ivarne merged commit 148d660 into master Dec 20, 2014
@ivarne ivarne deleted the nalimilan/join branch December 20, 2014 20:08
@ivarne
Copy link
Sponsor Member

ivarne commented Dec 20, 2014

By the way, none of the functions in manual/strings/ are clickable links. I tried to add :func: before the names, but it did not produce clickable links when generating locally with make html. Does anyone know what it would take?

@jiahao
Copy link
Member

jiahao commented Dec 20, 2014

@ivarne Sphinx doesn't know which namespace to use. You need to add .. currentmodule:: Base near the top of the file.

I pushed the necessary change to strings.rst in 6655241, you can go ahead and change the rest of the functions to be linkable.

@tkelman
Copy link
Contributor

tkelman commented Dec 21, 2014

docfix, @JuliaBackports?

@ivarne
Copy link
Sponsor Member

ivarne commented Dec 21, 2014

Thanks @jiahao! I don't have time the next week or so, but will eventually get to it if the backport pending label stays on.

nalimilan added a commit that referenced this pull request Dec 21, 2014
This is one of the very useful functions which can be hard to find,
and very similar to repeat().

(cherry picked from commit ef0e557)
ref PR #9426
@tkelman
Copy link
Contributor

tkelman commented Dec 21, 2014

backported in 4767284 (and @jiahao's followup in 7852bb0)

@ivarne
Copy link
Sponsor Member

ivarne commented Dec 22, 2014

Fixed more links in bf5a404 and backported in b296937

@nalimilan
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants