Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips for working with LLVM. #9385

Merged
merged 1 commit into from
Jan 5, 2015

Conversation

ArchRobison
Copy link
Contributor

This PR adds Julia-specific advice about LLVM to devdocs, culled from my notes from working on Julia. Hopefully others can extend it in the future.

-----------------------------------------------

To build with a different version of LLVM than the default,
edit ``deps/Versions.make``. Besides the LLVM release numerals, you can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it's a better recommendation to create a Make.user file that contains override LLVM_VER = svn or similar, rather than editing deps/Versions.make. That way your local git copy won't be dirty.

Very useful notes, though, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the education. I'll update the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Though your current phrasing

You can override it in your Make.user by adding a line such as:

might not make sense to someone who doesn't know what Make.user means, that file won't exist unless the user creates it. Since this might not be too well-documented elsewhere, or if it is then it's easy to miss, maybe a few more words saying to "Create a file called Make.user and add a line such as ... to it"?

@timholy
Copy link
Sponsor Member

timholy commented Dec 17, 2014

+1!

jakebolewski added a commit that referenced this pull request Jan 5, 2015
Add tips for working with LLVM.
@jakebolewski jakebolewski merged commit 86a2585 into JuliaLang:master Jan 5, 2015
@ArchRobison ArchRobison deleted the adr/docllvm branch January 5, 2015 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants