RFC: Fail fast on AppVeyor for repeated commits to the same PR #9355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d50712
to
b0a41af
Compare
Use AppVeyor's API! reuse cached version of jq instead of downloading every time make slightly more robust to network problems
b0a41af
to
346ebe3
Compare
|
@vtjnash I think this should do the trick. Due to the fetch, Appveyor will always checkout the latest relevant merge commit for a given PR, regardless of which commit triggered the build, how long it waited in the queue before starting, and what has happened on master in the meantime. So currently we could actually get redundant builds of the same content when someone pushes multiple times to the same PR. |
tkelman
added a commit
that referenced
this pull request
Dec 15, 2014
RFC: Fail fast on AppVeyor for repeated commits to the same PR
|
let's try this out and see how well it works (also backported in 36f0d62) |
|
Changes Unknown when pulling 346ebe3 on tkelman:tk/appveyor-failfast into * on JuliaLang:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To cut down on queue times. Opening this to test a few things.
AppVeyor runs:
at the start of a PR build. For queued builds to master we would need some more complicated logic but we might want to build every commit to master separately anyway.
The simple version of this (just checking
$APPVEYOR_REPO_COMMITagainstgit rev-parse HEAD) won't work if there's a new commit to master between the time the build gets queued and the time the build starts running, regardless of whether there are any newer commits to the PR branch.