Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pkg.build error message clearer. #9158

Merged
merged 1 commit into from
Dec 16, 2014
Merged

Make Pkg.build error message clearer. #9158

merged 1 commit into from
Dec 16, 2014

Conversation

lucasb-eyer
Copy link
Contributor

An itch I've long wanted to scratch.

Old:

WARNING: Images and IJulia had build errors.

 - packages with build errors remain installed in /home/beyer/.julia
 - build a package and all its dependencies with `Pkg.build(pkg)`
 - build a single package by running its `deps/build.jl` script

New:

WARNING: Images and IJulia had build errors.

 - packages with build errors remain installed in /home/beyer/.julia
 - build the package(s) and all dependencies with `Pkg.build("Images", "IJulia")`
 - build a single package by running its `deps/build.jl` script

@lucasb-eyer
Copy link
Contributor Author

I think Travis fails because of an unrelated

/bin/sh: 1: Syntax error: "(" unexpected

@staticfloat
Copy link
Sponsor Member

Yes, I like this change. The travis failure is unrelated.

@ivarne
Copy link
Sponsor Member

ivarne commented Nov 26, 2014

I like this too. Scheduling for @JuliaBackports?

@tkelman
Copy link
Contributor

tkelman commented Dec 16, 2014

Bump. I can't seem to get Travis to rebuild this one, could you push this again? Maybe rebase for the heck of it, though it's not strictly required since there are no conflicts here.

@lucasb-eyer
Copy link
Contributor Author

Rebased. I hope I did it right.

@ivarne
Copy link
Sponsor Member

ivarne commented Dec 16, 2014

Looks good!

ivarne added a commit that referenced this pull request Dec 16, 2014
Make `Pkg.build` error message clearer.
@ivarne ivarne merged commit a7ff9e0 into JuliaLang:master Dec 16, 2014
ivarne pushed a commit that referenced this pull request Dec 19, 2014
(cherry picked from commit 6ae21d1)
Ref: #9158
@ivarne
Copy link
Sponsor Member

ivarne commented Dec 19, 2014

Backported in 3f29e97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants