julia-mode.el: Highlight triple-quoted strings and characters. #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, '\U10ffff' was not highlighted correctly.
It's an expensive function, and julia-in-string handles characters anyway.
This is faster and less code.
This is warning is harmless (I'm not aware of any plans to remove `font-lock-syntactic-keywords`) but it has caused concern amongst users. See JuliaLang#9042
|
Sweet! |
|
@JeffBezanson I'd love to see this and #9024 merged. Are there any changes you'd like to me to make, or are you happy with them? |
JeffBezanson
added a commit
that referenced
this pull request
Nov 30, 2014
julia-mode.el: Highlight triple-quoted strings and characters.
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits improve julia-mode's string and character highlighting. We now correctly highlight all legal Julia character literals. I've also added proper support for highlighting triple quoted strings.
My refactoring also ensures we always set string delimeters as string syntax, which fixes #8714.