change argument order for rand! (fix #8246) #9092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API is
rand!([rng], [r::Range], A)
. There seems to be an almost consensus (cf. #8246) to putr::Range
as last argument, and a preference to keeprng
beforeA
, i.e:rand!([rng], A, [::Range])
. This PR implements this solution, but can easily be changed torand!(A, [rng], [::Range])
if a decision is made this way.Note:
r::Range
is also changed tor::AbstractArray
, to matchrand
.