Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's try just making this test a @test_approx_eq #8709

Merged
merged 3 commits into from
Oct 17, 2014

Conversation

staticfloat
Copy link
Sponsor Member

This should close #8708

@tkelman
Copy link
Contributor

tkelman commented Oct 17, 2014

Wrong number of arguments? And something's a little borked with the homebrew tap.

@staticfloat
Copy link
Sponsor Member Author

Everytime Apple releases a new minor version of OSX, the location of GCC libraries changes, because they're stored in the folder /usr/local/lib/gcc/x86_64-apple-darwinX.Y.Z. This is okay as long as I don't rebuild anything, but sometimes if I try to bump OpenBLAS, it will use the new value of Y, which means I then have to rebuild everything else as well, to use the new path.

@tkelman
Copy link
Contributor

tkelman commented Oct 17, 2014

Ugh. Why is it people like giving Apple all their money again?

@staticfloat
Copy link
Sponsor Member Author

It's actually not really Apple's fault, it's more of a gcc-on-OSX thing. I think it's mostly because of the impedance mismatch between how the Linux world likes to version directories, and how Apple likes to embed full paths into their dynamic libraries. But I digress. The whole reason for me setting up the buildbot thing was to make fixing these kinds of issues easier, so I'll just fix it. :P

@nolta
Copy link
Member

nolta commented Oct 17, 2014

@tkelman resumes polishing the Windows in his enormous glass palace.

@staticfloat
Copy link
Sponsor Member Author

@nolta I just sniggered so loudly my labmates are giving my strange looks

@tkelman
Copy link
Contributor

tkelman commented Oct 17, 2014

Nah Windows sucks even worse, I don't claim to prefer it at all. It's what I have and my machines are old. But given the option and assuming you know what you're doing before you buy the hardware, why anyone would choose Mac over Linux makes no sense to me.

@staticfloat
Copy link
Sponsor Member Author

Looks like it works now, and I bundled an OSX .travis.yml fix alongside it. I'm merging.

staticfloat added a commit that referenced this pull request Oct 17, 2014
Let's try just making this test a @test_approx_eq
@staticfloat staticfloat merged commit 11d6512 into master Oct 17, 2014
@JeffBezanson JeffBezanson deleted the sf/complex32-i686 branch October 25, 2014 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32-bit Complex number error
7 participants