Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put in instructions for getting release-0.3 instead of master #8642

Merged
merged 1 commit into from
Oct 9, 2014
Merged

Put in instructions for getting release-0.3 instead of master #8642

merged 1 commit into from
Oct 9, 2014

Conversation

IainNZ
Copy link
Member

@IainNZ IainNZ commented Oct 9, 2014

Wording can almost surely be improved, so feel free to change it directly instead of merging this PR.

Just wanted to put something in there to discourage people doing builds on master then complaining about packages being broken.

@StefanKarpinski
Copy link
Sponsor Member

We could change things so that release-0.3 is the default branch. That would make it so that cloning and doing make gives people something that they should be using, which may be a good idea.

@IainNZ
Copy link
Member Author

IainNZ commented Oct 9, 2014

That was definitely something that crossed my mind, but wasn't sure how much buy in there'd be for that. Would we switch back to master-default when we get to 0.4-pre stage?

@StefanKarpinski
Copy link
Sponsor Member

Yeah, just make the default branch at any point in time the one that we recommend people use. That seems like a pretty sane thing to do :-)

@ivarne
Copy link
Sponsor Member

ivarne commented Oct 9, 2014

Would that make it tedious to ensure that pull requests are suggested against master? Currently it is quite a few clicks to create a PR against release-0.3.

Changing default for git clone is not as problematic as I thought when I wrote that mailing list post now that I think of it.

@StefanKarpinski
Copy link
Sponsor Member

It is unfortunate that you can't separately change the default branch for cloning and the default branch for PRs and such. Or at least you can't that I know of.

@garborg
Copy link
Contributor

garborg commented Oct 9, 2014

Pardon my ignorance, but if someone clones Julia and repeatedly pulls &
makes, will the version change under their noses? Not saying that'd be
reason not to do it, but it seems that would break code unexpectedly if
true.

On Thu, Oct 9, 2014 at 12:22 PM, Ivar Nesje [email protected]
wrote:

Would that make it tedious to ensure that pull requests are suggested
against master? Currently it is quite a few clicks to create a PR against
release-0.3.

Changing default for git clone is not as problematic as I thought when I
wrote that mailing list post now that I think of it.


Reply to this email directly or view it on GitHub
#8642 (comment).

@StefanKarpinski
Copy link
Sponsor Member

No, it doesn't work like that – it's just the default branch that is initially checked out upon cloning.

@garborg
Copy link
Contributor

garborg commented Oct 9, 2014

OK, thanks.

@staticfloat
Copy link
Sponsor Member

I wish Github would just automatically open a PR against the branch that is closest to your proposed merge's branch. I just emailed them about it to get it on their radar. :P

@ivarne
Copy link
Sponsor Member

ivarne commented Oct 9, 2014

But until we find out how to make PR against a master more convenient with release-0.3 as default, I think this PR is an improvement. Should we just merge it?

@pao
Copy link
Member

pao commented Oct 9, 2014

Even if the default is changed, this isn't wrong.

pao added a commit that referenced this pull request Oct 9, 2014
Put in instructions for getting release-0.3 instead of master
@pao pao merged commit 2442478 into JuliaLang:master Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants