Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appdata file #8610

Merged
merged 1 commit into from
Oct 8, 2014
Merged

Add appdata file #8610

merged 1 commit into from
Oct 8, 2014

Conversation

palango
Copy link
Contributor

@palango palango commented Oct 7, 2014

This adds a basic appdata file as requested in #8438. I don't include screenshots so far as they wouldn't show much. Comments are appreciated.

@ViralBShah ViralBShah added system:linux Affects only Linux building Build system, or building Julia or its dependencies labels Oct 7, 2014
@nalimilan
Copy link
Member

Thanks for doing this! A screenshot of the startup screen with the colorful logo could be nice, if you're motivated enough. :-)

<application>
<id type="desktop">julia.desktop</id>
<metadata_license>CC-BY-SA-4.0</metadata_license>
<project_license>MIT</project_license>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I think for now this should be MIT and LGPLv2.1+ and GPLv2+. See LICENSE.md.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, only checked the top of the file. I'll update this and provide a screenshot. Can I store screenshots at the julia website?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can store it at https://julialang.org/images/julia.png, as there's already an ijulia.png file there. Then it could also be shown somewhere on the website if we want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding licenses, the exact string should be MIT and LGPL-2.1+ and GPL-2.0+

@nalimilan
Copy link
Member

Could you squash the two commits so that I can merge the branch? BTW, I guess you have checked the file is valid on the spec page?

@palango
Copy link
Contributor Author

palango commented Oct 8, 2014

Squashed the commits and validated the file. Should be ready to merge.

nalimilan added a commit that referenced this pull request Oct 8, 2014
@nalimilan nalimilan merged commit 49d87ad into JuliaLang:master Oct 8, 2014
@nalimilan
Copy link
Member

Perfect, thanks!

@JuliaBackports

@ivarne
Copy link
Sponsor Member

ivarne commented Oct 8, 2014

This backport conflicts with b382a74, Should I backport that also?

ivarne pushed a commit that referenced this pull request Oct 8, 2014
(cherry picked from commit b296f6a)
ref: #8610
@ivarne
Copy link
Sponsor Member

ivarne commented Oct 8, 2014

Backported in 216b758a and 769a592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies system:linux Affects only Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants