-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup make dist
#8024
Cleanup make dist
#8024
Conversation
DESTFILE=$(echo $DESTFILE | sed -e 's/[‘]\(.*\)[’]/\1/' ) | ||
|
||
# Do the chmod dance, but only if this is not a symlink (on linux) | ||
if [[ "$(uname -s)" == "Linux" && ! -h $DESTFILE ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this be needed on freebsd too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this again, I completely flummoxed this check. I have a much more resilient method in mind.
Oh and for BSD's this shouldn't rely on bash being installed. Posix sh only. |
Good reminder. I always default to |
Travis says line 10 is a bashism |
It wasn't the only one! :P I think I've got everything working now. |
Sweet! |
Wait, do we want to install versioned symlinks at all? Maybe |
It is best practice to install the versioned symlinks. I see no reason not to, since it's completely valid to try and dlopen |
As long as the symlinks are all relative-paths, get skipped in the Windows build (I can't find any on master so I think we're okay), and get properly preserved by archives, I guess it's fine then. |
Yes, they are definitely all relative. I think they don't get installed on Windows because the individual build processes for OpenBLAS, openlibm, etc... just don't create them on Windows. (At least, that's my guess without looking into it). Symlinks are preserved in |
Oddly libgmp does make a symlink at |
So we will not have this for 0.3? |
Ack, I thought this was merged days ago. We should probably have this to reduce distribution size, huh. |
Let me squash this, and then I'll merge and do some rebase magic. |
* No longer install anything related to libuv with `make dist` * Use custom `install` imposter; copy symlinks correctly to drastically reduce `make dist` size.
c210f65
to
e391c31
Compare
Isn't this what we have milestones for? |
Yes, I should have put this on a milestone. |
make dist
install
imposter; copy symlinks correctly to drastically reducemake dist
size.Tested on OSX and Linux (Ubuntu)