Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkbox for creation of the desktop shortcut and branding text #7412

Merged
merged 1 commit into from
Jun 26, 2014
Merged

Added checkbox for creation of the desktop shortcut and branding text #7412

merged 1 commit into from
Jun 26, 2014

Conversation

gilfernandes
Copy link
Contributor

Hello,

I have added to the Julia installer a checkbox for the creation of the desktop shortcut and added the branding text too. In the processes I had to change the includes. Now Ithe script is including MUI2.nsh instead of MUI.nsh.

The following screenshots show the changes:

image

image

Please let me know, if the changes are OK.

I can continue to contribute to this installer, so also new suggestions would be appreciated.

Regards,

Gil

@tkelman
Copy link
Contributor

tkelman commented Jun 25, 2014

Neat. Does it default to on or off? (I'd prefer off, but maybe that's just me)

@gilfernandes
Copy link
Contributor Author

The "Create desktop shortcut" check box defaults to off.

ihnorton added a commit that referenced this pull request Jun 26, 2014
Added checkbox for creation of the desktop shortcut and branding text
@ihnorton ihnorton merged commit e892c77 into JuliaLang:master Jun 26, 2014
@ihnorton
Copy link
Member

Thanks!

@tkelman
Copy link
Contributor

tkelman commented Jun 26, 2014

Oh, if you want to look further into the installer, I've noticed I keep getting an annoying message from Windows (7) saying "This program may not have been installed correctly." No idea what triggers that warning, and I've been ignoring it, but would be nice to figure out where it comes from and get rid of it. The "author" in that message has also been coming up as the author of 7zip, rather than the authors of Julia. I'll try to remember to post a screenshot of the message next time I install a new nightly.

@ihnorton
Copy link
Member

3f23167 gets rid of the message, at least in User-mode install. We would still need to handle UAC correctly to make it work in all situations, I think.

@tkelman
Copy link
Contributor

tkelman commented Jun 26, 2014

Ugh, registry. Thanks. I'm not sure which is worse, the warning or having to touch the registry to prevent it.

@ihnorton
Copy link
Member

Yeah, I know. When in Rome...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants