added reflection method #7322

mauro3 · 2014-06-19T18:54:23Z

As far as I know, when using using it is not easy to find out which module a particular binding came from. At least when the object the binding points to does not contain that data, like for instance a variable.

This adds a method and a macro to do that:

julia> Base.@binding_module sin
Base

julia> Base.@binding_module a
ERROR: Symbol a is not bound in the current module Main and not exported in any 'used' module.
 in error at error.jl:21
 in binding_module at reflection.jl:171

julia> a = 4
4

julia> Base.@binding_module a
Main

julia> Base.binding_module(:a)
Main

If this is of interest, someone should have a look at the c-code! And I will add some test. Should it be exported? If so function_module should probably be exported too.

JeffBezanson · 2014-06-19T19:34:35Z

src/module.c

@@ -90,6 +90,13 @@ jl_binding_t *jl_get_binding_wr(jl_module_t *m, jl_sym_t *var)
 return *bp;
 }

+// return module of binding
+DLLEXPORT jl_module_t *jl_get_module_of_binding(jl_sym_t *var)


This should take a module argument instead of only using the current module.

JeffBezanson · 2014-06-19T19:36:01Z

Maybe this should be added to @which, if the argument is just a symbol?

StefanKarpinski · 2014-06-20T18:26:04Z

I'd like to begin printing named objects like functions and types with fully qualified names, which would largely eliminate this problem without requiring reflection (although allowing reflection is still good).

mauro3 · 2014-06-20T18:43:33Z

Variables were the main reason I looked into this. Would variables also be printed like so:

julia> e
Base.e = 2.7182818284590...

Maybe a bit too cluttered?

JeffBezanson · 2014-06-20T18:54:09Z

No, because there is no way to do that --- values do not have canonical names. If I say x=2; y=x, should entering y print x=2?

StefanKarpinski · 2014-06-20T19:02:37Z

Generic functions and types are special in that they do have canonical names based on where they were first defined. Most kinds of values do not have this property. (Where was 1 defined?)

brianpiper · 2014-06-20T20:36:22Z

I give a +1 for something like this, at least. I think it makes sense for exported variables to have some kind of reflection to see which module they came from. The function/macro could return module from where the symbol was exported from (if it was). It's somewhat similar to the Base.function_module function then.

JeffBezanson · 2014-06-20T20:37:32Z

I think @which x would be a good way to do this.

mauro3 · 2014-06-20T21:22:42Z

Values do not carry around where they were defined, but their bindings do. This is what this PR can uncover.

@JeffBezanson, thanks for the comments, I'll implement them.

mauro3 · 2014-06-24T22:13:57Z

I added the module to the call signature of jl_get_module_of_binding, and its friend binding_module in reflection.jl. @which can now be used with symbols, and I took the liberty to let it run for builtin functions as well:

julia> @which pi
Base

julia> @which help
Base.Help

julia> @which isa
Core

julia> @which isa(5, Int)
isa

julia> @which tt
ERROR: Symbol tt is not bound in the module Main and not exported by any module 'used' within Main.
 in error at error.jl:21
 in binding_module at reflection.jl:172
 in which at interactiveutil.jl:206

Let me know whether this is ok, and I still needs some tests.

mauro3 · 2014-06-24T22:15:30Z

base/interactiveutil.jl

 typesof(args...) = map(a->(isa(a,Type) ? Type{a} : typeof(a)), args)

 function gen_call_with_extracted_types(fcn, ex0)
+ if isa(ex0, Symbol)
+ return :($fcn(symbol($(string(ex0)))) )


Here I need to preserve ex0 as symbol. Is there a better way to do this?

$(Expr(:quote, ex0))

Or:

Meta.quot(:ex0)

mauro3 · 2014-06-25T12:55:10Z

Here the complete thing. It is ready to be merged as far as I am concerned.

A few things to ponder and maybe update in this PR:

Should @which return the builtin-function if called like e.g. @which isa? This makes it type unstable for Callables. (This is what this PR currently does.)
Should @which do something special for DataTypes or Modules?

mauro3 · 2014-09-09T07:51:44Z

Ping. Any interest in this, should I add/change something? Or should I close the PR?

nolta · 2014-09-20T22:52:41Z

doc/juliadoc

@@ -1 +1 @@
-Subproject commit fe3db7224daf4798ac950f7aa2c6ae7b60b85491
+Subproject commit 85361bb67d6eedb8ee956b5c09f50ae547cf7b7a


I think I once changed that to get python 3.0 compatibility and forgot about it.

mauro3 · 2014-09-30T21:57:43Z

@nolta fixed.

JeffBezanson · 2014-12-08T20:31:21Z

src/module.c

+// return module of binding
+DLLEXPORT jl_module_t *jl_get_module_of_binding(jl_module_t *m, jl_sym_t *var)
+{
+ jl_binding_t *b = (jl_binding_t*)ptrhash_get(&m->bindings, var);


This needs to use jl_get_binding and check for NULL.

mauro3 · 2015-01-08T14:00:05Z

src/module.c

+ jl_binding_t *b = jl_get_binding((*bp)->owner, var);
+ return b->owner;
+}
+


@JeffBezanson: I'm not sure this addresses your concerns. It certainly does not check for NULL but maybe the HT_NOTFOUND is good too? This is the best I could come up with my trial-and-error approach. If this is not good either explain more, or give me a test case which fails due to the bug, or update it yourself.

jl_get_binding might return NULL if the symbol is unbound. You should only need to call jl_get_binding, check for NULL, and otherwise return b->owner. The ptrhash_bp call is unnecessary and there are other conditions you would need to check (duplicating jl_get_binding -- see its definition in modules.c)

mauro3 · 2015-01-08T14:03:44Z

Rebased and updated according to Jeff's line-comment.

ihnorton · 2015-01-09T04:49:03Z

Looks fine to me now, other than some whitespace error somewhere (see travis)

mauro3 · 2015-01-09T09:12:56Z

Squashed the commits and made a couple of cosmetical changes. But I cannot figure out what error Travis is reporting. (Build runs fine on my Linux machine.) Sorry, but could you explain on how to read: https://travis-ci.org/JuliaLang/julia/jobs/46417667 ?

mauro3 · 2015-01-09T11:52:13Z

Ok, my bad: some blocker in Firefox made the Travis site not show the actual error report, thus I was confused. Now fixed the whitespace issue.

mauro3 · 2015-01-14T19:51:11Z

Bump. I think this is ready to be merged.

mauro3 · 2015-02-12T16:45:17Z

Fixed white-space issue.

Use with `@which variable`. Includes tests and update of docs.

mauro3 · 2015-03-29T20:52:10Z

Wanted to use this functionality just now, so bumping.

added reflection method

tkelman · 2015-04-22T05:41:47Z

base/interactiveutil.jl

@@ -222,6 +222,9 @@ code_warntype(f, t::(Type...)) = code_warntype(STDOUT, f, t)
 typesof(args...) = map(a->(isa(a,Type) ? Type{a} : typeof(a)), args)

 function gen_call_with_extracted_types(fcn, ex0)
+ if isa(ex0, Symbol)


odd 5-space indent here... also seems strange to me that this isn't using dispatch?

You're right, just a bit too late & sorry. Fixed in #10944

@tkelman

as suggested by @tkelman

Small cosmetic correction to merged PR #7322

@tkelman

as suggested by @tkelman

@tkelman

as suggested by @tkelman

JeffBezanson reviewed Jun 19, 2014
View reviewed changes

mauro3 reviewed Jun 24, 2014
View reviewed changes

nolta reviewed Sep 20, 2014
View reviewed changes

mauro3 force-pushed the bindings_reflection branch 2 times, most recently from 89d4140 to 4ab7eaf Compare September 30, 2014 21:52

jiahao force-pushed the master branch 2 times, most recently from 2ef98c5 to 0388647 Compare October 5, 2014 00:57

mauro3 mentioned this pull request Oct 11, 2014

RFC: Documentation System #8588

Closed

jiahao force-pushed the master branch from 6c7c7e3 to 1a4c02f Compare October 11, 2014 22:06

jiahao force-pushed the master branch from cdde4df to 7fdc860 Compare October 28, 2014 04:20

MikeInnes force-pushed the master branch from 5c60996 to b1c3df3 Compare November 14, 2014 17:07

JeffBezanson reviewed Dec 8, 2014
View reviewed changes

mauro3 force-pushed the bindings_reflection branch from 4ab7eaf to ad62b17 Compare January 8, 2015 13:57

mauro3 reviewed Jan 8, 2015
View reviewed changes

mauro3 force-pushed the bindings_reflection branch from 0ae3d6e to 6a6f6e7 Compare January 9, 2015 08:45

mauro3 force-pushed the bindings_reflection branch from 6a6f6e7 to 216d361 Compare January 9, 2015 11:50

mauro3 force-pushed the bindings_reflection branch 2 times, most recently from a75a27f to befc5f2 Compare February 12, 2015 16:44

Added reflection method for bindings

e75f2ce

Use with `@which variable`. Includes tests and update of docs.

mauro3 force-pushed the bindings_reflection branch from befc5f2 to e75f2ce Compare March 29, 2015 20:50

JeffBezanson added a commit that referenced this pull request Apr 21, 2015

Merge pull request #7322 from mauro3/bindings_reflection

855dc64

added reflection method

JeffBezanson merged commit 855dc64 into JuliaLang:master Apr 21, 2015

tkelman reviewed Apr 22, 2015
View reviewed changes

mauro3 added a commit to mauro3/julia that referenced this pull request Apr 22, 2015

Small cosmetic correction to merged PR JuliaLang#7322

59d7a37

as suggested by @tkelman

mauro3 mentioned this pull request Apr 22, 2015

Small cosmetic correction to merged PR #7322 #10944

Merged

tkelman added a commit that referenced this pull request Apr 22, 2015

Merge pull request #10944 from mauro3/m3/bindings_reflection_followup

5e99f74

Small cosmetic correction to merged PR #7322

mauro3 deleted the bindings_reflection branch April 23, 2015 05:29

carnaval pushed a commit that referenced this pull request Apr 27, 2015

Small cosmetic correction to merged PR #7322

69f1304

as suggested by @tkelman

tkelman mentioned this pull request May 1, 2015

reflection test failure when run with include_from_node1 #11092

Closed

mbauman pushed a commit to mbauman/julia that referenced this pull request Jun 6, 2015

Small cosmetic correction to merged PR JuliaLang#7322

eeb2a21

as suggested by @tkelman

ihnorton mentioned this pull request Oct 2, 2015

Make methods(::Symbol) an error, fixes #13398 #13415

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added reflection method #7322

added reflection method #7322

mauro3 commented Jun 19, 2014

JeffBezanson Jun 19, 2014

JeffBezanson commented Jun 19, 2014

StefanKarpinski commented Jun 20, 2014

mauro3 commented Jun 20, 2014

JeffBezanson commented Jun 20, 2014

StefanKarpinski commented Jun 20, 2014

brianpiper commented Jun 20, 2014

JeffBezanson commented Jun 20, 2014

mauro3 commented Jun 20, 2014

mauro3 commented Jun 24, 2014

mauro3 Jun 24, 2014

JeffBezanson Jun 24, 2014

jakebolewski Jun 24, 2014

mauro3 commented Jun 25, 2014

mauro3 commented Sep 9, 2014

nolta Sep 20, 2014

mauro3 Sep 22, 2014

mauro3 commented Sep 30, 2014

JeffBezanson Dec 8, 2014

mauro3 Jan 8, 2015

ihnorton Jan 8, 2015

mauro3 commented Jan 8, 2015

ihnorton commented Jan 9, 2015

mauro3 commented Jan 9, 2015

mauro3 commented Jan 9, 2015

mauro3 commented Jan 14, 2015

mauro3 commented Feb 12, 2015

mauro3 commented Mar 29, 2015

tkelman Apr 22, 2015

mauro3 Apr 22, 2015

		@@ -1 +1 @@
		Subproject commit fe3db7224daf4798ac950f7aa2c6ae7b60b85491
		Subproject commit 85361bb67d6eedb8ee956b5c09f50ae547cf7b7a

added reflection method #7322

added reflection method #7322

Conversation

mauro3 commented Jun 19, 2014

Choose a reason for hiding this comment

JeffBezanson commented Jun 19, 2014

StefanKarpinski commented Jun 20, 2014

mauro3 commented Jun 20, 2014

JeffBezanson commented Jun 20, 2014

StefanKarpinski commented Jun 20, 2014

brianpiper commented Jun 20, 2014

JeffBezanson commented Jun 20, 2014

mauro3 commented Jun 20, 2014

mauro3 commented Jun 24, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mauro3 commented Jun 25, 2014

mauro3 commented Sep 9, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mauro3 commented Sep 30, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mauro3 commented Jan 8, 2015

ihnorton commented Jan 9, 2015

mauro3 commented Jan 9, 2015

mauro3 commented Jan 9, 2015

mauro3 commented Jan 14, 2015

mauro3 commented Feb 12, 2015

mauro3 commented Mar 29, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment