Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor mallocarray_t to reflect it should carry jl_genericmemory_t #55237

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jul 24, 2024

Seems like this mallocarray_t container is only carrying objects of type jl_genericmemory_t after the memory work.

Let's:

  • Rename the container type to mallocmemory_t.
  • Make the payload type a bit more strict to ensure a bit more type safety (i.e. change the a field from jl_value_t * to jl_genericmemory_t *).
  • Add a comment to indicate the pointer tagging in the lowest bit of the payload.

@d-netto d-netto added the GC Garbage collector label Jul 24, 2024
@d-netto d-netto force-pushed the dcn-refactor-mallocmemory_t branch 2 times, most recently from b7e41c2 to 4d6171b Compare July 25, 2024 00:32
src/gc.h Outdated Show resolved Hide resolved
@d-netto d-netto force-pushed the dcn-refactor-mallocmemory_t branch 2 times, most recently from 3d33750 to c9bc2fa Compare July 25, 2024 14:16
@d-netto d-netto force-pushed the dcn-refactor-mallocmemory_t branch from c9bc2fa to 77514e7 Compare July 25, 2024 14:17
@d-netto
Copy link
Member Author

d-netto commented Jul 25, 2024

Will merge since the only failure in x86_64-linux-gnuassertrr-net seems unrelated (and this test is currently flaky).

@d-netto d-netto merged commit bbb4403 into master Jul 25, 2024
5 of 7 checks passed
@d-netto d-netto deleted the dcn-refactor-mallocmemory_t branch July 25, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants